Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Fix regression where inserts into reference tables with a different name on sharded keyspaces were not routed correctly. (#15796) #15860

Merged
merged 2 commits into from
May 8, 2024
Merged

[release-19.0] Fix regression where inserts into reference tables with a different name on sharded keyspaces were not routed correctly. (#15796) #15860

merged 2 commits into from
May 8, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented May 7, 2024

Description

This is a backport of #15796

@vitess-bot
Fix regression where inserts into reference tables with a different n…
3b5d2c2 
…ame on sharded keyspaces were not routed correctly. (#15796)

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner May 7, 2024 13:02
@vitess-bot vitess-bot
Copy link
Contributor Author

vitess-bot bot commented May 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from rohit-nayak-ps May 7, 2024 13:02
@github-actions github-actions bot added this to the v19.0.4 milestone May 7, 2024
@rohit-nayak-ps
Update statement is different from v20, hence needed to handle update…
3b613eb 
…s in addition to inserts for v19

Signed-off-by: Rohit Nayak <[email protected]>
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.47%. Comparing base (2c42825) to head (3b613eb).

Files Patch % Lines
.../vt/vtgate/planbuilder/operators/route_planning.go 77.77% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/update.go 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-19.0   #15860      +/-   ##
================================================
- Coverage         67.47%   67.47%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192780   192794      +14     
================================================
+ Hits             130076   130084       +8     
- Misses            62704    62710       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harshit-gangal
harshit-gangal reviewed May 8, 2024
View reviewed changes
go/vt/vtgate/planbuilder/operators/route_planning.go
case *sqlparser.Insert:
stmt.Table = refTbl
default:
panic("unsupported DML type in buildVindexTableForDML")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not panic here and return vterrors.VT13001

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this function doesn't return an error and the standard pattern used is to panic here and catch panics at an outer level.

harshit-gangal
harshit-gangal approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment. Rest looks good.

@systay systay mentioned this pull request May 8, 2024
Closed
25 tasks
@rohit-nayak-ps rohit-nayak-ps merged commit b158b69 into release-19.0 May 8, 2024
199 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the backport-15796-to-release-19.0 branch May 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Backport This is a backport Component: Query Serving Type: Bug Type: Regression
Projects
None yet
Milestone
v19.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@harshit-gangal @rohit-nayak-ps